AllenInstitute / AllenInstitute/ConnectsCommonConnectivity

CellFeatureMeasurement: feature_set_id and unit are never generated

Open Beginner friendly
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug schema
Dominant language
Jupyter Notebook
Stars
4
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Problem: cell_features_schema.yaml declares feature_set_id and unit for CellFeatureMeasurement under slot_usage: but not under slots:. LinkML generates neither, so models.py lacks both fields — the documented "denormalized reference to the feature set" doesn't exist.

Fix: declare both under slots:; regenerate models.

Related: whether feature sets are project-scoped is #35 — don't silently add the ProjectScoped mixin here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open cell_features_schema.yaml and inspect the CellFeatureMeasurement declarations under slot_usage and slots. Regenerate the models as the repository workflow specifies, then verify that models.py contains feature_set_id and unit without adding the ProjectScoped mixin.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.