AllenInstitute / AllenInstitute/ConnectsCommonConnectivity
dry_run silently ignored when output_root is passed
Open
Beginner friendly
Nobody has claimed this yet.
bug
good first issue
io
- Dominant language
- Jupyter Notebook
- Stars
- 4
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem: write_models(..., output_root=...) resolves settings=None, so dry_run=True is silently ignored and data is written.
Fix: honor dry_run; add the missing test.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the write_models implementation and trace how output_root resolves settings. Add a regression test for output_root with dry_run=True, verifying that no data is written; the issue is complete when the test passes and dry-run behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100