AllenInstitute / AllenInstitute/AllenSDK

use requests (vs. urllib) in json_utilities

Open
#281 0 comments 0 reactions 1 assignee View on GitHub

@NileGraddis is already working on this.

Since Oct 19, 2018.

noprogram
Dominant language
Jupyter Notebook
Stars
398
Forks
163
No merged PRs in 30d

Description

json_utilities.read_url_get and json_utilities.read_url_post use urllib to submit http requests. This functionality underlies much of the api subpackage. Replacing urllib with requests would have a few advantages:

  1. code written with requests is cleaner
  2. we could use a tool like responses to more selectively mock API calls in our tests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.