AllenInstitute / AllenInstitute/ACE
Fix bookmarking
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 4
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
I have pasted back most of the bookmarking text from earlier versions of the app from the files below; however, this still does not work.
To fix this one of two things will need to happen:
- Figure out why Lucas' bookmark workaround code isn't working
- Get the actual bookmarking method implemented by RShiny working, in which case I should be able to remove the bookmark_function.R file.
This is important because it lets folks save specific states of the app.
File location is here: https://github.com/AllenInstitute/annotation_comparison/blob/2def60e88164ba4f8c5ebe0df06bbe07554b31f9/R/bookmark_functions.R
Bookmarking code in this server file: https://github.com/AllenInstitute/annotation_comparison/blob/2def60e88164ba4f8c5ebe0df06bbe07554b31f9/R/server.R
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading R/bookmark_functions.R and the bookmarking code in R/server.R to determine which implementation is currently used and why it fails. Run the app and verify that users can save and restore specific app states; completion means one working bookmarking approach remains and the obsolete workaround can be removed if appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100