AllenFang / AllenFang/react-bootstrap-table

deleteRow confirmation dialog can suppress future deletions

Open
#577 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
2.2k
Forks
761
PR merge metrics
No merged PRs in 30d

Description

When deleting a row (which I am doing through calling handleDropRow), a confirmation dialog appears.

screen shot 2016-07-21 at 9 55 02 am

If I check 'Prevent this page from creating additional dialogs', then on subsequent calls to handleDropRow, the row does not get deleted and there is no indication that a delete was attempted, even after reload of the page.

I have fixed this by using handleConfirmDeleteRow and calling next() to skip the confirmation, which works just fine, but I do not think the ability to prevent row deletions with that checkbox should be the default behavior.

This is using Chrome Version 51.0.2704.103.

Thanks for all the work on this great package!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.