AllTheMods / AllTheMods/AllTheModium

[BUG] There is no Max Limit for AbsorptionAmount

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
Java
Stars
18
Forks
41
PR merge metrics
No merged PRs in 30d

Description

It stacks and starts to cause FPS issues which results in the game becoming unplayable. Editing player data to reset it to 0 fixes the issue until it starts to stack up again. Going from 120 FPS to 8 in roughly 20-30 hits

(Added) The absorption(after testing) appears to be adding when using a tinker's weapon/tool that has the "laceration" property(Nahuitl and Vibranium)
It is also healing players through the same Lacerating "Tinker" Modifier, that have +X Max Health modifiers on their armor.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a Tinker's weapon or tool using the Laceration property, especially Nahuitl or Vibranium, and observe AbsorptionAmount after repeated hits. Trace the absorption handling and verify that repeated hits cannot cause FPS degradation or unintended healing through Laceration; done means the value remains bounded and gameplay stays usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.