AllTheMods / AllTheMods/AllTheModium
soul lava still emits particles when enclosed
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 18
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
when incorporating soul lava into a build of mine, i noticed that soul lava doesnt share a subtle behavior of normal lava. when you cover the top of a lava source block, the embers that pop off the surface stop appearing. soul lava source blocks, however, still spawn soul flame particles even if enclosed on all sides, and these particles also appear to pass through solid blocks. this small discrepancy causes enclosed soul lava features in builds to emit soul particles which undesirably pass through into open spaces.
ATM10 7.0
allthemodium 3.0.1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in ATM10 7.0 with AllTheModium 3.0.1 by enclosing normal lava and soul lava source blocks on all sides. Compare their particle behavior and trace the soul lava particle implementation from there. Done means enclosed soul lava no longer emits particles through solid blocks, matching normal lava.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100