AlgebraicJulia / AlgebraicJulia/Semagrams.jl

Reversion: API Change for Viewports and out of date comments

Đang mở
#140 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Scala
Star
108
Fork
10
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

@sjbreiner I should have caught this when reviewing your PR, but you changed the API for viewports from viewports having their own element to viewports attaching children to the main window. Except, only the MainViewport attaches children to the main window. And deregistration does *nothing* to change this. So essentially the entire viewport API is now pointless; the whole point was that different things could have different scaling and with your current design this no longer is possible.

Now, I think that it makes sense to refactor this anyways, because I think that `EditorState` is going to be split up into things that are window-level, and things that are Semagram-level, and perhaps this removes the necessity of having separate viewports because what we termed "UI" could now be handled outside of the Semagram itself, though perhaps still overlaid.

That being said... it was not best development practices, and further more the comments are out of date now. Again, I should have caught this while reviewing, but in the future when breaking an API please remember to change the comments.

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.