AlgebraicJulia / AlgebraicJulia/Catlab.jl

Coproduct with looseACSetTransformations

Open
#908 2 comments 0 reactions 1 assignee Claimed by @kris-brown View on GitHub
bug
Dominant language
Julia
Stars
724
Forks
73
PR merge metrics
No merged PRs in 30d

Description

@slwu89 has found a bug in the `coproduct` dispatch:

```julia
X = @acset LabeledSet{Symbol} begin
X=4
label=[:a,:b,:c,:d]
end

Y = @acset LabeledSet{Int} begin
X=3
label=1:3
end

g = (Label=FinFunction(Dict([l=>l for l in X[:,:label]])),)
h = (Label=FinFunction(Dict([l=>Symbol(l) for l in Y[:,:label]])),)
coproduct(X,Y, type_components=[g,h])
```

Dispatch is not working, as it should eventually turn into the following (which does work, if you directly type it in):

```julia
colimit(Tuple{LabeledSet{Symbol},LooseACSetTransformation},
DiscreteDiagram([X,Y]);
type_components=[g,h])
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.