AlgebraicJulia / AlgebraicJulia/Catlab.jl

Refactor FinSets from FinSetImpls, etc

Aperta
#889 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
cleanup
Lingua principale
Julia
Stelle
724
Fork
73
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

"It's something unpredictable//But in the end it's right..."
--Billie Joe Armstrong

It's too hard to have `FinDomFunction` and `FinSet` be abstract types. Make them and others concrete types according to the general design

```julia
abstract type FinSetImpl
struct FinSet
theSet::FinSetImpl
end
```

Then we refactor so that the majority of functions involving sets and functions act on the pseudo-concrete wrapper types, which means you can't access details of the implementation, but on the other hand you can map over something without constantly freaking out over whether it's a collection of `FinDomFunctionDict`s or `FinDomFunctionVector`s.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.