AlexsLemonade / AlexsLemonade/sc-data-integration

Consider removing occurrences of `aes_string()`

Open
#212 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Currently, many of our plotting functions use `aes_string()` to handle data mappings. This function has been deprecated in newer `ggplot2` versions, so we may want to think about moving away from this strategy and instead using `aes()` with so-called "curly-curly"'s`{{}}`.
Although I am opening this issue in this repo, this code change might/is(?) something we should do elsewhere (`scpca-nf`?), since this repo is more internal. But, I didn't want to forget this so filing here now!

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate all plotting functions that use aes_string() and review whether the related work belongs in this repository or scpca-nf. Confirm the scope before changing mappings to aes() with {{}}; done means the in-scope occurrences are migrated and the plotting behavior remains working.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.