Aiven-Open / Aiven-Open/klaw

refactor(coral): Replace custom Pagination with Aquarium Pagination

Open
#714 1 comment 0 reactions 0 assignees View on GitHub
Frontend Housekeeping
Dominant language
Java
Stars
195
Forks
77
Avg merge
8d 9h
Merged PRs (30d)
1

Description

# What is currently missing?

We have a custom `Pagination` component (`src/app/components/Pagination`). The reasons for it to exist are twofold:
- sub-optimal: shortcomings in a11y for Aquarium's Pagination (screen reader desctipions are not enough to know that the component is a Pagination UI)
- breaking: a bug that prevented us from setting an initial page from the URL search params (https://github.com/aiven/design-system/issues/946)

Using custom components when one already exists in Aquarium is not desirable at this point.

# How could this be improved?

The breaking issue has been resolved, and will be released in an upcoming Aquarium version. We should consider using the component as soon as the bug is fixed in the released version, and opening an issue with the Aquarium project to fix the a11y ambiguity.

Todo:
- replace use of custom `Pagination` by Aquarium's `Pagination`
- delet custom `Pagination`
- open a11y issue in the Aquarium project

# Is this a feature you would work on yourself?

* [ ] I plan to open a pull request for this feature

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.