Aiven-Open / Aiven-Open/klaw

reafctor(coral): Add `RequestApprovalTable` generic component

未关闭
#617 0 条评论 0 个 reaction 已指派 1 人 已被 @mathieu-anderson 认领 在 GitHub 查看
enhancement Frontend
主要语言
Java
星标
195
派生
77
平均合并
8 天 9 小时
30 天内合并 PR
1

描述

# What is currently missing?

A lot of UI and logic is shared between tables handling request approvals, most notably the `View details`, `Approve` and `Reject` columns with button icons.

This leads to a significant amount of duplication, which exposes us to discrepancies and bugs.

# How could this be improved?

We could implement a generic `RequestApprovalTable` component which would handle both:
- the specific columns rendering the UI for the approval/rejection business logic
- the actual approval/rejection business logic
- taking in the specific columns needed for each type of request approval

A first approach (only functional for ACL requests) cabn be seen here: https://github.com/aiven/klaw/pull/616

# Blockers

The API currently has one endpoint per type of request to approve. There is a plan to have a single endpoint to approve of types of requests, which would simplify the implementation of this refactor.

Draft PR: https://github.com/aiven/klaw/pull/623/files

# Is this a feature you would work on yourself?

* [ ] I plan to open a pull request for this feature

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。