Aiven-Open / Aiven-Open/klaw

feat(coral): Idea - Add highlight on search term in tables

Aberta
#1,820 0 comentários 0 reações 0 responsáveis Ver no GitHub
enhancement Frontend
Linguagem predominante
Java
Estrelas
195
Forks
77
Merge médio
8d 9h
PRs com merge (30d)
1

Descrição

# What is currently missing?

The search field in tables is sometimes ambiguous as to *what* it searches. For example, here we are matching `TST`, `default`, `UAT`, but it's unclear:

![Screenshot 2023-09-29 at 12 47 01](https://github.com/Aiven-Open/klaw/assets/20607294/429cb2d5-b22d-49fb-9817-f34d56a4c8f9)

# How could this be improved?

We could implement highlighting of search terms in results, like in this proof of concept:

https://github.com/Aiven-Open/klaw/assets/20607294/9880c6b1-3980-45b8-bd90-fd797abb95ef

Code POC visible here: https://github.com/Aiven-Open/klaw/commit/c1b249b900b9ea76952d4eb3f7ed846fcd4bec7f

# Questions

This is a bit of a big task, given that it should be added to every table with a `search` filed (which is most of them). It also brings in an additional dependency for the highlighting (we might want to build such a feature ourselves, but it might not be worth the time).

# Other information

This is tied to this issue as well: [bug(coral/core): The `search` param in some endpoints matches on data which is not displayed](https://github.com/Aiven-Open/klaw/issues/1821)

# Is this a feature you would work on yourself?

- [ ] I plan to open a pull request for this feature

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.