AhsanAyaz / AhsanAyaz/ngx-device-detector
device detector is flagging ipad and iphone devices as desktop
- Lingua principale
- TypeScript
- Stelle
- 560
- Fork
- 106
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
**Describe the bug**
After upgrading to the latest version we have identified that the isDesktop function is returning true for iphone and ipad devices. We have also noticed the same result when trying out this app:
https://koderlabs.github.io/ngx-device-detector/demo/
We have attached screenshots of what it returns.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to '[https://koderlabs.github.io/ngx-device-detector/demo/](https://koderlabs.github.io/ngx-device-detector/demo/)'
2. Click on 'N/A.'
3. Scroll down to 'isDesktop'
4. isDesktop is returning true for iphone and iPad
**Expected behavior**
From what I understand (do correct me if I am wrong), the isDesktop function should return false for iphone/ipad devices which appeared to be the case in the earlier version we have used (which was 2.0.5). I was wondering if this commit might have caused this issue perhaps: https://github.com/KoderLabs/ngx-device-detector/commit/cea0f9edcfc77620b3b8621af23cfbf39811f645?
**Screenshots**
ipad:

iphone:

**Ipad (please complete the following information):**
- Device: iPad Air 2
- OS: iOS 15.1
- Browser Safari
- Version 15.1
**Ipad (please complete the following information):**
- Device: iPad 5th generation
- OS: iOS15.1
- Browser Safari
- Version iPad 5th generation
**Smartphone (please complete the following information):**
- Device: Iphone 13
- OS: IoS15.1
- Browser Safari
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.