Adyen / Adyen/adyen-java-api-library

[Chore] Add @Override to generated OpenAPI schemas

Open Beginner friendly
#2,053 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

do not stale
Dominant language
Java
Stars
148
Forks
158
Avg merge
3d 3h
Merged PRs (30d)
10

Description

Context

Generated AbstractOpenApiSchema classes override equals(Object) without an @Override annotation. The omission originates in templates-v7/libraries/jersey3/AbstractOpenApiSchema.mustache and affects existing generated classes, including the Document Collector models reviewed in PR #2045.

Proposed Change

Add @Override immediately above equals(Object) in the AbstractOpenApiSchema.mustache template, then regenerate the affected models through the standard SDK automation flow.

Benefit

Makes the override explicit, lets the compiler validate the method signature, and aligns these generated classes with the existing POJO template convention. This is a readability and maintainability improvement with no expected behavior change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with templates-v7/libraries/jersey3/AbstractOpenApiSchema.mustache and inspect the generated equals(Object) method. Add the annotation in the template, then use the standard SDK automation flow to regenerate the affected models. Done means the regenerated AbstractOpenApiSchema classes include @Override above equals(Object) without behavior changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.