AdvancedCustomFields / AdvancedCustomFields/acf

Fix jQuery deprecations

Open
#916 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

My browser console is really cluttered with jQuery migrate deprecation warnings which is really not nice when developing. Most of them belongs to ACF scripts.

To Reproduce
Steps to reproduce the behavior:

  1. Edit a post on the block editor
  2. Open your devtools
  3. Select the "console" tab
  4. Look for your console.log between hundred of lines of deprecation warnings

Expected behavior

No deprecations.

Version Information:

  • WordPress Version: 6.5
  • PHP Version: 8.2
  • ACF Version: ACF PRO 6.3
  • Browser: Chrome

Additional context

Most of those deprecations are really easy to fix. It seems to be mostly event related functions like .keypress() -> .on('keypress'), etc.

Your are developers too, I'm pretty sure you can understand how annoying this can be 🙏

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by editing a post in the block editor and reviewing the browser console in Chrome. Trace the jQuery Migrate warnings back to the ACF scripts, focusing on the event-related calls mentioned in the report. Done means the reported deprecation warnings no longer appear while developing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.