AdvancedCustomFields / AdvancedCustomFields/acf

Should the block HTML switch always be set to false for ACF blocks?

Open
#696 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

Hey @lgladdy,

for testing I have activated the HTML switch for ACF blocks in block.json:

    "supports": {
        "html": true
    }

I noticed that this doesn't work and causes a block error:

https://user-images.githubusercontent.com/31563167/186605341-9614a41f-c02b-4829-8513-897dff1f9f99.mp4

After doing that, the ACF block is transformed to a paragraph block.

Should the block HTML switch always be set to false for ACF blocks users?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with an ACF block whose block.json sets supports.html to true, as described in the issue. Trace how that setting is handled before the block is transformed into a paragraph, then define the expected behavior for the HTML switch and verify it against the reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.