AdvancedCustomFields / AdvancedCustomFields/acf
$sitepress->get_setting() not available in very old version of WPML
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
WPML used to offer free versions which cannot be live-updated. With those versions (I have 2.6.x installed), $sitepress->get_setting() causes the site to crash due to "method undefined" error.
How about returning false for is_translatable() if the method $sitepress->get_setting() does not exist?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in includes/wpml.php at line 71, where $sitepress->get_setting() is called. Check how is_translatable() handles the WPML integration, then verify that installations lacking get_setting() no longer crash and return false instead. The issue does not mention a test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100