AdvancedCustomFields / AdvancedCustomFields/acf
Usage of strtolower breaks accented translations
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
In the render_field_checkbox() we use strtolower to convert the category name into lowercase. This is used to fill the show_option_none label.
This breaks category name when it contains accented characters (e.g. Catégorie which is Category in French).
This wouls be better to use mb_strtolower function to take into account various encoding.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open includes/fields/class-acf-field-taxonomy.php around render_field_checkbox() and the referenced lines. Check how the category name is converted for the show_option_none label, then verify that accented names such as “Catégorie” remain intact and run the relevant field taxonomy tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, internationalization
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100