AdvancedCustomFields / AdvancedCustomFields/acf

ACF Blocks break 'Featured Image' selection

Open
#607 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

I found a bug using ACF Blocks: It occurs when you edit a post which contains an ACF Block in edit mode which has at least one image field (might happen with other fields too). If you reload or revisit the page after the first save and you try to select the post's featured image, this is what you'll see:

Screenshot 2022-02-03 at 17 48 28

The selected image is always the first box of the grid and it's always empty. It's still possible to select other thumbnails and the selection will also be saved correctly, but visually it's always wrong when coming back to this window.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in a post containing an ACF Block in edit mode with an image field, then reload or revisit the post and open the featured image selector. Compare the displayed selected thumbnail with the saved selection; done means the correct image is shown rather than the empty first grid box.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
content, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.