AdvancedCustomFields / AdvancedCustomFields/acf

Moving multiple blocks into innerblock breaks Gutenberg

Open
#543 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

When moving multiple blocks into an innerblock, the whole page breaks.

Here is the error:

TypeError: Cannot read property 'firstChild' of null
    at pp (https://websiteurl.hidden/wp-includes/js/dist/block-editor.min.js?ver=390a9f83b606a55e8b523c4d16bdb08c:12:393446)
    at https://websiteurl.hidden/wp-includes/js/dist/block-editor.min.js?ver=390a9f83b606a55e8b523c4d16bdb08c:12:394426
    at Bh (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:126:456)
    at Dj (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:476)
    at unstable_runWithPriority (https://websiteurl.hidden/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)
    at Da (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:60:280)
    at xb (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:231)
    at Te (https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:146:79)
    at https://websiteurl.hidden/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:61:68
    at unstable_runWithPriority (https://websiteurl.hidden/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)

And here is a gif of the error:
jQ9xkXCyZF

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by moving multiple blocks into an inner block in the Gutenberg editor, then inspect the block-editor.min.js stack trace and the React DOM calls shown in the report. Done means the page remains usable and the TypeError about firstChild no longer occurs; the issue names no source file or test to start from.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, wordpress
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.