AdvancedCustomFields / AdvancedCustomFields/acf

acf_register_block_type needs "version" param

Open
#516 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

The acf_enqueue_block_type_assets function relies on the wp_enqueue_style to build style links for blocks. By default, setting the $ver param in wp_enqueue_style to "false" will make the code add a version query to the style links equal to the current version of WordPress. This causes caching issues from the server, in CDNs, and on the client machine.

Can we add a "version" param to acf_register_block_type so we can get around this issue?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing acf_register_block_type and acf_enqueue_block_type_assets, then inspect how the block registration data reaches wp_enqueue_style. The work is done when a supplied version controls the generated block style links instead of WordPress's default version, with the behavior verified against the existing block asset tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.