AdvancedCustomFields / AdvancedCustomFields/acf

'Block > is equal to > All' not triggering re-render of admin page.

Open
#512 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

Hi there,

I have a very specific problem. I've added an ACF field group that applied to all blocks using the following location rules:
Block > is equal to > All

This allows me to add custom margin, padding, animation (and a bunch of other global things) to all of my blocks, rather than manually adding that functionality per block. It wraps each template using a render callback.

I would expect updating any of these fields would trigger a re-render of the Gutenberg ACF block previews, but it doesn't. The fields do update, but only after manually refreshing the page. I think this means JSX isn't behaving properly.

Is this a bug, or is it working as intended? If it's not a bug - is there a way of making ACF fields to trigger Gutenberg's state to update? Thanks for your help in advance!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report concerns ACF field groups using “Block > is equal to > All,” render callbacks, and Gutenberg block previews; no file or test is named. First reproduce the behavior in the Gutenberg admin by changing one of the global fields, then trace how the preview responds. Done means field changes trigger the block preview to re-render without manually refreshing the page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.