AdvancedCustomFields / AdvancedCustomFields/acf

Loading symbol on front end forms oddly placed.

Open
#47 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

When displaying a Field Group on the front end via acf_form() the loading symbol that appears on submit often appears in something random - or seemingly random. Seems like it should be moved inside the submit button so it's consistent. I'm happy to submit a patch for this but would like to know if such a patch would be accepted.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the acf_form() front-end Field Group rendering and trace where the submit loading symbol is positioned. Confirm how the form submit button is generated and identify the existing loading-indicator behavior. Done means the symbol consistently appears inside the submit button when the form is submitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.