AdvancedCustomFields / AdvancedCustomFields/acf

Flexible Content breaking when one field has an & in the name

Open
#449 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

Just wanted to highlight a bug I've found.

I have a few different blocks in a Flexible Content field, one of which was called Text & Media. This saved the name as text_&_media. The use of this cause the field to fail, the json file to render invalid and a few other bugs.

Changing this to Text and Media fixed the issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with an Advanced Custom Fields Flexible Content field containing a block named "Text & Media" and inspect the saved name and rendered JSON. Confirm that the field works and the generated JSON remains valid when the block name contains an ampersand.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
content
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.