AdvancedCustomFields / AdvancedCustomFields/acf
Use flex instead of float for the fields
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Recently I've been trying to make a small columns field for ACF, and with that I ran into one little problem: the floats being used on the fields. Maybe it's a good idea to change this to flex? The change won't be much work I recon (it still uses the custom width system etc), and it makes the system just a bit more modern. No min height needs to be set anymore either, as flex takes care of that.
If wanted, I would also be willing to make this change to the code and send it as a pull request to be implemented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the field layout styles that currently use floats, the custom width system, and a minimum height. Verify that the proposed flex layout preserves custom widths and removes the minimum-height requirement; done means the fields retain their intended column layout without float-based styling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100