AdvancedCustomFields / AdvancedCustomFields/acf
Version 5.9 savePost() hotfix
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Description
The recent ACF 5.9 release contains a bug causing various issues surrounding the saving and previewing of posts. This bug stems from our JS solution to enable AJAX validation for metaboxes whilst an official API is provided.
In this solution, we wrap the core savePost() function in our own logic. Our mistake was to ignore the specific return type (a Promise object) of this function, which we have now fixed 👍.
Solution
Please download and replace the following two JS files found in the hotfix/version-5-9-savepost branch:
- /assets/js/acf-input.js
- /assets/js/acf-input.min.js
Testing
Please provide feedback via the comments section below, so we can roll out an update as quickly as possible.
Thanks from the ACF team.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the hotfix/version-5-9-savepost branch and compare assets/js/acf-input.js with assets/js/acf-input.min.js. Confirm the savePost wrapper preserves the Promise return type, then test saving and previewing posts with AJAX metabox validation; done means the reported 5.9 regressions no longer occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 15/100