AdvancedCustomFields / AdvancedCustomFields/acf
<iframe> tag entered into the field instructions isn't escaped
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Bug:
- I created a Text Area field so editors can insert a video
<iframe>from YouTube. - When I added
<iframe>to the instructions and saved the field? The entire editor gets thrown into the unclosed<iframe>tag. - When I change
<iframe>to<iframe>in the description, everything works fine.
Details:
- WordPress 5.5
- WooCommerce 4.3.2
- ACF Pro 5.9-RC1
- Chrome 86 (Developer Edition)
Screenshots:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a Text Area field whose instructions contain <iframe>, using the WordPress, WooCommerce, ACF, and Chrome versions listed. Trace how the field instructions are rendered in the editor. Done means the literal tag no longer breaks the editor, while normal instructions still display correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100