AdvancedCustomFields / AdvancedCustomFields/acf

5.9.0-beta4 - Block recovery inside InnerBlocks

Open
#343 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

I have tried a few blocks and it fails to let me recover anything from invalid InnerBlocks. It has the "attempt block recovery" option and "resolve" but neither actually do anything or resolve the issue when I press them.

It's not important for now since you can just remove and re-make the block. Actually just pressing save again and then reloading the editor seems to somehow fix it.

(For context, this happens when you change the markup of any block used inside of an InnerBlocks group. It's intended for this to happen but the issue here is we can't actually resolve it using the options available and it seems broken)

I'm using the latest Gutenberg plugin.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in the latest Gutenberg plugin by changing the markup of a block used inside an InnerBlocks group, then use the available recovery and resolve options. Check whether invalid InnerBlocks can be recovered without recreating the block, and verify the behavior against the reported save-and-reload workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.