AdvancedCustomFields / AdvancedCustomFields/acf
Cancel on "Insert/edit link" popup still changes value
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Current behaviour:
The "cancel" button in the "Inser/edit link" popup still transfers any value input into the popup to the link.
Expected behaviour:
The popup closes and the link's value remains unchanged
Steps to reproduce:
-
Create a custom field with the type "link"
-
Navigate to where it the field is and click "Select Link"
-
Input anything in the URL field and click "cancel"
-
Link is now selected even though it shouldn't be
-
This can now be repeated by clicking the "edit"-pen
Versions tested:
WordPress 5.3.2 and 5.4.1
ACF 5.8.11 as well as ACF Pro 5.8.7 and 5.8.11
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a custom Link field using the listed steps, then inspect the implementation of the “Insert/edit link” popup and its cancel action. Done means cancel closes the popup without changing the existing link value, including after reopening it with the edit control.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100