AdvancedCustomFields / AdvancedCustomFields/acf

'_acf_changed' value sets to "1" at first form on page, not at really changed

Open
#239 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
945
Forks
197
PR merge metrics
No merged PRs in 30d

Description

assets/js/acf-input.js:5311
$('#_acf_changed').val(1);

If page has 2 or more acf-forms, and any form field value changed, hidden field '_acf_changed' value sets to "1" at first form, not at really changed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect assets/js/acf-input.js around line 5311 and reproduce the behavior with a page containing two or more ACF forms. Verify which form's fields trigger the _acf_changed hidden value, then use the existing JavaScript tests or form behavior to confirm that only the form whose field changed is marked.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.