AdvancedCustomFields / AdvancedCustomFields/acf
Time Picker with backslash
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I'm using in a project the time picker field.
array(
'key' => 'field_5d949a4f1d277',
'label' => __( 'Due' ),
'name' => 'tma_due',
'type' => 'time_picker',
'instructions' => '',
'required' => 0,
'conditional_logic' => 0,
'wrapper' => array(
'width' => '',
'class' => '',
'id' => '',
),
'display_format' => 'H\hi',
'return_format' => 'U',
),
The display_format seems to broke the Time picker.
In the Firefox console I've this message:
How to make it works ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the time picker implementation and trace how the display_format value 'H\hi' is passed into the picker, using the Firefox console error as the initial clue. Reproduce the issue with the configuration shown and confirm that the time picker works with the corrected handling of the backslash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100