AdvancedCustomFields / AdvancedCustomFields/acf
Taxonomy field ignores accented characters when checking if a term exists
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Steps to reproduce
- Using the ACF taxonomy term, insert a new term without using characters: e.g. Commes des Garcons
- Then try and insert a new term with accented characters: e.g. Comme des Garçons. ACF considers them identical and won't add it.
- The default WP taxonomy admin pages does treat the two names as different, and will let you add them both.
Admittedly, a bit of an edge case, but client ran into this issue on a site that handles a lot of accented characters. They had incorrectly spelt a term, but when they tried to correct it by adding a new term with the correct accented characters, the ACF field refused to insert it. I'm guessing it compares against the slug rather than the term name itself. While you can edit the terms using WP's default taxonomy menus, I prefer to not show those in the admin to simplify things for the end client.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the ACF taxonomy field's term-existence check and compare it with how the default WordPress taxonomy admin handles “Commes des Garcons” and “Comme des Garçons.” Done means distinct terms that differ only by accented characters can both be added through the ACF taxonomy field, without changing the existing behavior for genuinely identical terms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- content
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100