AdvancedCustomFields / AdvancedCustomFields/acf
Please don’t remote load images
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
The new release has this:
/includes/admin/views/settings-info.php:18:
<p><img src="https://assets.advancedcustomfields.com/info/5.0.0/select2.png" /></p>
/includes/admin/views/settings-info.php:23:
<p><img src="https://assets.advancedcustomfields.com/info/5.0.0/design.png" /></p>
/includes/admin/views/settings-info.php:28:
<p><img src="https://assets.advancedcustomfields.com/info/5.0.0/sub-fields.png" /></p>
This is against the WordPress.org plugin guidelines, since remote loading images may cause you to track usage which gets rolled into GDPR issues, among others. Can you please patch that?
You can email plugins@wordpress.org for more info, but I’m pretty sure that was just a mistake and nothing malicious 🙃
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with includes/admin/views/settings-info.php at the three reported image references. Inspect how the plugin packages admin assets and replace the remote image loading with an appropriate local arrangement. Confirm the settings information view no longer requests images from assets.advancedcustomfields.com.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100