AdvancedCustomFields / AdvancedCustomFields/acf
ACF_render_field_setting "Tab" doesn't work in field group administration
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 945
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
Hello!
When adding a tab as a field setting using acf_render_field_setting() in the administration of a field group, the tab doesn't appear. Looks like it isn't initialized by JavaScript.
It seems like the bug appeared in ACF 5.7 (Working as intended in ACF 5.6).
Tested from ACF 5.7.10 to 5.8.0 beta 4.
JS Console error: TypeError: tabs is undefined in acf-input.js:8097:9
render: function( $el ){
this.getTabs().map(function( tabs ){
if( !tabs.get('initialized') ) {
tabs.initializeTabs();
}
});
},
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the field-group administration case with ACF 5.7.10 through 5.8.0 beta 4, then inspect the render function around acf-input.js:8097 and the acf_render_field_setting() path. Compare behavior with ACF 5.6; done means the added Tab setting appears and initializes without the reported JavaScript console error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100