AdobeDocs / AdobeDocs/commerce-php

The add new carrier example won't obey free shipping rules

Open
#227 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11
Forks
177
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### What's missing?

In the guide for `Add a custom shipping carrier` https://developer.adobe.com/commerce/php/tutorials/frontend/custom-checkout/add-shipping-carrier/ it seems the example is missing critical functionality

The new carrier is added properly but it won't obey free shipping rules from cart rules because the collectTotals method is not accounting for that.

A fully working example should be given for a simple method to actually help developers build proper shipping methods.

If you could clarify this point it would help a lot.

Contributor guide

Open the contributing guide

Research direction

Start with the “Add a custom shipping carrier” guide at the linked Adobe Commerce documentation URL, focusing on the example’s collectTotals method and its handling of cart-rule free shipping. Update the example and explanatory text so the carrier demonstrates a working free-shipping-aware method, then verify the guide clearly explains the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.