AdguardTeam / AdguardTeam/urlfilter

Some Comments Break Filtering

Open
#9 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
116
Forks
27
PR merge metrics
No merged PRs in 30d

Description

@Cybo1927 commented on [Fri Oct 23 2020](https://github.com/AdguardTeam/AdGuardHome/issues/2214)

### Prerequisites

Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.**

- [x] I am running the latest version
- [ ] I checked the documentation and found no answer
- [ ] I checked to make sure that this issue has not already been filed

### Issue Details

* **Version of AdGuard Home server:**
* 0.103.3
* **How did you setup DNS configuration:**
* System
* **If it's a router or IoT, please write device model:**
*
* **Operating system and version:**
* openSUSE Tumbleweed x86_64 (Kernel: 5.8.14-1-default)

### Expected Behavior
When you have a website blacklisted which also has a comment (such as, `||grabify.link #Comment`) it should still filter the domain

### Actual Behavior
The blocking is bypassed because of the comment

### Screenshots

Screenshot:

https://i.imgur.com/kFkXPmY.png

https://i.imgur.com/pu9oEDp.png

### Additional Information
It works with filters in non adblock syntax such as `https://gitlab.com/quidsup/notrack-blocklists/raw/master/notrack-malware.txt`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.