AdguardTeam / AdguardTeam/SafariConverterLib

Improve `$genericblock` implementation

未关闭
#69 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
enhancement Priority: P4
主要语言
Swift
星标
78
派生
20
PR 合并指标
30 天内没有已合并 PR

描述

In the current implementation `$genericblock` is basically the same as `$document`, i.e. it disables filtering completely.

This implementation can be improved if we change the way the list is ordered.

Here's how the rules should be ordered:

1. Generic `css-display-none` rules
2. `$generichide` `ignore-previous-rules`
3. Generic url blocking rules
4. `$genericblock` `ignore-previous-rules`
5. Domain-specific `css-display-none rules`
6. `$elemhide` `ignore-previous-rules`
7. Domain-specific url blocking rules
8. `$urlblock` ignore-previous-rules

In addition to that `$genericblock` rules' `resource-types` should be limited and exclude `document`. In this case it will not cover cosmetic rules.

Actually, when we add [ignore-following-rules](https://github.com/AdguardTeam/SafariConverterLib/issues/87) support, it will be easier to solve it.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。