AdguardTeam / AdguardTeam/AdGuardHome

Reallow the use of ED25519 keys.

Open
#8,324 0 comments 7 reactions 1 assignee Claimed by @Chinaski1 View on GitHub
feature request Priority: P4
Dominant language
TypeScript
Stars
36.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

### Prerequisites

- [x] I have checked the [Wiki](https://github.com/AdguardTeam/AdGuardHome/wiki) and [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions) and found no answer

- [x] I have searched other issues and found no duplicates

- [x] I want to request a feature or enhancement and not ask a question

### The problem

AdGuard as described here (https://github.com/AdguardTeam/AdGuardHome/issues/3737#issue-1027374918) actively blocks the key exchange algorithm "ED25519".
I also get the message "validating certificate pair: ED25519 keys are not supported by browsers; did you mean to use X25519 for key exchange?" and I'm unable to click on save configuration.

### Proposed solution

Firstly more and more browsers support ED25519 and last time I checked all major browsers are supporting it. Secondly should it be the users choice of which algorithm his system uses? Thirdly if you only have machine <-> machine communication for the AdGuard server (e.g. in an intranet for servers or behind a reverse proxy like caddy) it is irrelevant if clients are supporting it.

So as I listed it is not really not necessary to block ED25519 and removes the free choices of users, so please **re allow** ED25519.

### Alternatives considered and additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.