AdguardTeam / AdguardTeam/AdGuardHome

Strict file mode (permissions) setting?

Ouverte
#3,200 4 commentaires 5 réactions 1 personne assignée Réclamée par @ainar-g Voir sur GitHub
enhancement P3: Medium
Langage dominant
TypeScript
Étoiles
36.9k
Forks
2.5k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently, AGH creates most of its files and directories with permissions like `0o644` (`-rw-r--r--`) for non-executable files and `0o755` (`-rwxr-xr-x`) for executables and directories. CWE and securego.io recommend these to be no greater than `0o600` (`-rw-------`) and `0o750` (`-rwxr-x---`) correspondingly.

I propose that we add a setting, `strict_file_mode`, which makes AGH make these `0o600` and `0o750`/`0o700`. I would like it to be set to `true` by default, but that could break people's backup and other scripts. Perhaps it should only be `true` for new installations?

@ameshkov, what do you think?

Related:

* #764.
* #3198.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.