AdguardTeam / AdguardTeam/AdGuardDNS

Try to improve the fallback approach

Open
#654 9 comments 1 reaction 1 assignee Claimed by @ainar-g View on GitHub
feature request Priority: P4
Dominant language
Go
Stars
952
Forks
82
PR merge metrics
No merged PRs in 30d

Description

### Issue Details

First of all, why do we need a fallback? We faced issues with nameservers for unknown reasons preventing access from our name servers. There were not too many, but still this is a pretty problematic issue for AdGuard DNS users.

Currently, we do the following: if the recursor returns a `SERVFAIL` response, AG DNS tries to use a fallback.

Unfortunately, this leads to issues like that: https://github.com/AdguardTeam/AdGuardDNS/issues/653

### Proposed solution

1. The simple solution would be to use the fallback only once per eTLD+1 domain. If the fallback also returns a `SERVFAIL` response for that domain name, remember this and don't use the fallback anymore.
2. Disable fallbacks for specific domain zones.

### Alternative solution

If we had a pure go recursor implementation we could come up with a more sophisticated solution, but we don't.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.