Addepar / Addepar/ember-table

More complete basic CSS would be useful

Open
#996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

First let me say that with only having started to use EmberTable a few days ago I am very impressed with the package and its documentation. I followed the very clear and useful documentation to get myself started rendering tables very quickly. However, I ran into a few problems with the rendering. For example, when I got to trying to use EmberTh::SortIndicator, no indicator was visible in my application. It took me a bit of digging with the web developer tools comparing my page to the documentation pages (where the sort indicators are visible) to find that the problem was that in the distribution there are no CSS specifications for the et-sort-indicator class.

I was able to solve my problem by just copying all of the ember-table CSS from the documentation site into my app.css file. That solved my sort indicator problem and all of the other formatting oddities I was experiencing, and provides me a good starting point for adjusting the style to meet my needs.

It would be nice, however, if the distribution came with a more complete set of basic CSS. Or if the documentation included instructions on what CSS the user is expected to provide for themselves. Or if there is a more straightforward way to get a basic functional CSS, it would be nice to have that more prominently explained in the documentation.

Thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the ember-table CSS on the documentation site with the distribution, focusing on the missing et-sort-indicator styling and the other formatting differences described. Review how users are expected to include styles in their app.css and determine whether the completed work should add basic CSS to the distribution or clarify the setup in the documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.