Addepar / Addepar/ember-table

ember-table-loading-more throws TypeError when calling this.element while being destroyed

Open
#993 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

44.261Z » TypeError: Cannot read properties of null (reading 'style')
    at Class.setIncludedInLayout (https://localhost/assets/vendor.js:183484:20)

// while caught in the debugger we get...
15:35:24.232 this.element
15:35:24.250 null
15:35:25.496 this.isDestroyed
15:35:25.520 true
15:35:34.480 this.isDestroying
15:35:34.499 true

https://github.com/Addepar/ember-table/blob/bb71932fad208f04c65ccd02d97b649413ed5ef4/addon/components/ember-table-loading-more/component.js#L174

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in addon/components/ember-table-loading-more/component.js around line 174, where the error is reported, and inspect the component's destruction state shown in the issue. Reproduce the loading-more destruction path and verify that it no longer throws a TypeError when this.element is null during teardown.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.