Addepar / Addepar/ember-table

Table header highlight not showing on hover

Open
#947 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

I am trying to have sorting enabled on my table. When a user clicks on a header, the client does an API request to fetch sorted data based on the column. This functionality works w/ the following:

<t.head
  @columns={{@tableColumns}}
  @onUpdateSorts={{this.handleColumnHeaderClick}}
  @widthConstraint="eq-container"
  as |h|
>
  <h.row as |r|>
    <r.cell class="FileManager_tableCell" as |column columnMeta|>
      <span class="FileManager_tableHeader">
        {{column.name}}
        {{#if column.isSortable}}
          {{alloy-icon name='sort' size='small'}}
        {{/if}}
      </span>
    </r.cell>
  </h.row>
</t.head>

However when I hover my mouse, I don't get the highlight css.

The tableColumns I passed in is:

tableColumns = [
    { name: '', valuePath: 'fileType', textAlign: 'right', width: 50, isSortable: false },
    { name: 'Name', valuePath: 'name', textAlign: 'left', width: 300, isSortable: true },
    { name: 'Location', valuePath: 'location', textAlign: 'left', width: 100, isSortable: true },
    { name: 'Shared with', valuePath: 'sharedWith', textAlign: 'left', width: 100, isSortable: false },
    { name: 'Last used', valuePath: 'lastUsed', textAlign: 'left', width: 50, isSortable: true },
    { name: '', width: 50 },
  ],

Am I missing something here?

Running "ember-table": "^3.3.1",

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided table-header example with ember-table 3.3.1 and inspect the header hover styling used by the table components. Done means sortable table headers visibly receive the expected highlight when hovered, while the reported sorting behavior continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.