Addepar / Addepar/ember-table

Why ResizeSensor is a global?

Open
#909 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

Hey,

why don't we import the ResizeSensor at table-sticky-polyfill like every module?

Why:
https://github.com/Addepar/ember-table/blob/204315adfb7a98cf0be6f8428818b37a57e34895/addon/-private/sticky/table-sticky-polyfill.js#L1

instead of

import { ResizeSensor } from "css-element-queries";

Best regards!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at addon/-private/sticky/table-sticky-polyfill.js around line 1 and inspect how ResizeSensor is currently referenced. Compare that usage with the proposed import from css-element-queries; done means the module's dependency handling and the reason for using a global are clarified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.