Addepar / Addepar/ember-table

Table does not accept valuePath with dots

Open
#891 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

When trying to render the following table:

  columns = [
    {
      name: "id",
      valuePath: "id",
    },
    {
      name: "value path with dot",
      valuePath: "a.b",
    },
  ];

  rows = [
    { id: 0, "a.b": 2 },
    { id: 1, "a.b": 3 },
  ];
<EmberTable as |t|>
    <t.head @columns={{this.columns}} />

    <t.body @rows={{this.rows}} />
 </EmberTable>

It does not render the values from the column that has a dot (.) on the value path

image

I don't know if this should actually be fixed, but, if not, we can add this on the documentation saying that those are not supported.

Ember Version: 3.17.0 (i've also tested with 3.22 and the same problem happens)
EmberTable Version: 3.0.1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the example from the issue with Ember 3.17 or 3.22 and EmberTable 3.0.1, then trace how the table resolves valuePath for row values. Done means either dotted keys render correctly or the limitation is documented clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.