Build issue with latest embroider
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 351
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 1
Description
Embroider now throws an error if the string passed to hbs is not a string literal.
Build Error (OneShot)
ember-table/components/-private/row-wrapper.js: /Users/akatz/Source/project-repo-root/ember-table/components/-private/row-wrapper.js: hbs accepts only a string literal argument (This is an error on an internal node. Probably an internal error. Location has been estimated.)
23 | });
24 |
> 25 | const layout = hbs`{{yield api}}`;
| ^^^
26 |
27 | export default Component.extend({
This appears to be coming from here: https://github.com/embroider-build/embroider/blob/031ce6d8a3137f5df6106be26c336b92ed948717/packages/core/src/babel-plugin-inline-hbs.ts#L212
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the build with the latest Embroider, then inspect ember-table/components/-private/row-wrapper.js and the linked Embroider babel-plugin-inline-hbs.ts location. The work is done when the project builds successfully without the hbs string-literal error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100