Addepar / Addepar/ember-table

[FEATURE-REQ] Ability to show loading spinner/text until the actual table row data is rendered

Open
#838 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

First of all, great work on the add-on. Keep doing the great job.

It is a very common case where in, a particular component that is using the ember-table, has to fetch row data from remote via ember-concurrency task (instead of resolving in route's model hook) and there is a delay in actual data being bound and sent down to the ember-table.

In this scenario, it becomes a necessity to show a loader text or a spinner in the table body, until the actual data is received and rendered, for an acceptable/better user experience.

<EmberTable as |table|>
  <table.body
    ...
    @isLoading = {{this.fetchDataTask.isRunning}}
    @tableLoader = "Please wait ..."
    ...>
  </table.body>
<EmberTable>

(This also matches parity with ember-light-table in this particular aspect.)
Thanks in advance.

Thoughts on this, guys ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the EmberTable table.body API and how it currently receives and renders row data. Define the loading behavior around the ember-concurrency task state, including the loader text or spinner shown while rows are pending, and verify that the actual rows replace it once data is rendered.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.