Addepar / Addepar/ember-table

cellComponent not working with Octane components

Open
#826 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
351
Avg merge
1d 22h
Merged PRs (30d)
1

Description

cellComponent doesn't appear to be working with Ember Octane components:

routes/mytable.js

model = { 
  columns: [
  {
    name: "Foo",
    valuePath: "foo"
  }, {
    name: "Test",
    cellComponent: 'test'
  }
],
rows: [
  {
    "foo": "This is a test",
  }
]}

components/test.hbs

<p>Testing component</p>

templates/mytable.hbs

<EmberTable as |t|>
       <t.head 
          @columns={{@model.columns}} 
          @enableResize={{true}} 
          @enableReorder={{false}} 
          @sorts={{@model.sorts}}
          @onUpdateSorts={{action (mut @model.sorts)}} />
       <t.body @rows={{model.rows}} />
</EmberTable>

This results in the table rendering as expected, with the first column displaying "This is a test" as expected, but nothing appearing in the second column with the cellComponent.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction in routes/mytable.js, components/test.hbs, and templates/mytable.hbs, then run the table with the shown columns and rows. Compare the working valuePath column with the cellComponent column; done means the second column renders “Testing component” for the provided row.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.